Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removing securitycontrols.md and security control tags from experimentation #811

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

johnswayty-ssc
Copy link
Collaborator

Ran into an issue with the last PR kindly review this one. Apologies.

fmichaelobrien
fmichaelobrien previously approved these changes Feb 2, 2024
Copy link
Contributor

@fmichaelobrien fmichaelobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

tackaberry
tackaberry previously approved these changes Feb 2, 2024
Copy link
Collaborator

@alaincormier-ssc alaincormier-ssc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

reminder if we want to bump the release tags, to add "fix:" in the PR/commit title before merging

@johnswayty-ssc johnswayty-ssc changed the title Removing securitycontrols.md and security control tags from experimentation fix: Removing securitycontrols.md and security control tags from experimentation Feb 5, 2024
Copy link
Collaborator

@lucstjean-ssc lucstjean-ssc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@fmichaelobrien fmichaelobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Collaborator

@tackaberry tackaberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@johnswayty-ssc johnswayty-ssc merged commit f17ff29 into main Feb 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants